donnerpeter commented on pull request #2277:
URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773471401
As for this:
```
// TODO: can these flags change throughout the file? If not then we can
abort sooner. And
// then we wouldn't even need to create a temp file for the affix stream
- a large enough
// leading buffer (BufferedInputStream) would be sufficient?
```
Flags aren't supposed to be redefined, although Hunspell currently silently
(and I believe erroneously) allows that. Aborting sooner is possible, but would
need a bit more code.
I'd very much like to avoid a temp file, but I don't understand how. I don't
think we can fix the size of the temp buffer in advance and expect all aff
files to obey that, some of them include large comments in the beginning. And
unfortunately, the files themselves can be quite large: for Kinyarwanda it's
38MB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
