donnerpeter commented on a change in pull request #2376: URL: https://github.com/apache/lucene-solr/pull/2376#discussion_r576832415
########## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ########## @@ -1085,8 +1062,9 @@ private void writeNormalizedWordEntry( int sep = flagSep < 0 ? morphSep : flagSep; CharSequence toWrite; - if (needsInputCleaning) { - cleanInput(line, sep, reuse); + String beforeSep = line.substring(0, sep); + if (needsInputCleaning(beforeSep)) { Review comment: Removed the `cleanInput` overload with prefixLen as it complicates code and doesn't seem to be of benefit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org