[
https://issues.apache.org/jira/browse/SOLR-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter reopened SOLR-15149:
---------------------------------------
Assignee: Alessandro Benedetti
These changes are causing lots of jenkins test failures, and fail locally for
me – seemingly regardless of seed...
{noformat}
-
org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.multipleAdditiveTreesTestUnknownFeature
(:solr:contrib:ltr)
Test output:
/home/hossman/lucene/dev/solr/contrib/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.txt
Reproduce with: gradlew :solr:contrib:ltr:test --tests
"org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.multipleAdditiveTreesTestUnknownFeature"
-Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=1A4BA65E1F8DC9A4 -Ptests.file.encoding=US-ASCII
-
org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.multipleAdditiveTreesTestMissingFeatureStore
(:solr:contrib:ltr)
Test output:
/home/hossman/lucene/dev/solr/contrib/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.txt
Reproduce with: gradlew :solr:contrib:ltr:test --tests
"org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.multipleAdditiveTreesTestMissingFeatureStore"
-Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=1A4BA65E1F8DC9A4 -Ptests.file.encoding=US-ASCII
-
org.apache.solr.ltr.model.TestLinearModel.notExistentFeature_shouldThrowMeaningFulException
(:solr:contrib:ltr)
Test output:
/home/hossman/lucene/dev/solr/contrib/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.model.TestLinearModel.txt
Reproduce with: gradlew :solr:contrib:ltr:test --tests
"org.apache.solr.ltr.model.TestLinearModel.notExistentFeature_shouldThrowMeaningFulException"
-Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=1A4BA65E1F8DC9A4 -Ptests.file.encoding=US-ASCII
-
org.apache.solr.ltr.model.TestLinearModel.notExistentStore_shouldThrowMeaningFulException
(:solr:contrib:ltr)
Test output:
/home/hossman/lucene/dev/solr/contrib/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.model.TestLinearModel.txt
Reproduce with: gradlew :solr:contrib:ltr:test --tests
"org.apache.solr.ltr.model.TestLinearModel.notExistentStore_shouldThrowMeaningFulException"
-Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=1A4BA65E1F8DC9A4 -Ptests.file.encoding=US-ASCII
hossman@slate:~/lucene/dev [j11] [*master] $ ./gradlew :solr:contrib:ltr:test
--tests
"org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.multipleAdditiveTreesTestUnknownFeature"
> Task :randomizationInfo
Running tests with randomization seed: tests.seed=CC3A0F73B2AA5EA6
> Task :solr:contrib:ltr:test FAILED
org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel >
multipleAdditiveTreesTestUnknownFeature FAILED
org.junit.ComparisonFailure: expected:<...lException: Feature:[]notExist1
not found ...> but was:<...lException: Feature:[ ]notExist1 not found ...>
at
__randomizedtesting.SeedInfo.seed([CC3A0F73B2AA5EA6:E26C09F90579A786]:0)
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at
org.apache.solr.ltr.model.TestMultipleAdditiveTreesModel.multipleAdditiveTreesTestUnknownFeature(TestMultipleAdditiveTreesModel.java:250)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754)
hossman@slate:~/lucene/dev [j11] [*master] $ ./gradlew :solr:contrib:ltr:test
--tests
"org.apache.solr.ltr.model.TestLinearModel.notExistentFeature_shouldThrowMeaningFulException"
-Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
> Task :randomizationInfo
Running tests with randomization seed: tests.seed=73B50C5A7808D84B
> Task :solr:contrib:ltr:test FAILED
org.apache.solr.ltr.model.TestLinearModel >
notExistentFeature_shouldThrowMeaningFulException FAILED
org.junit.ComparisonFailure: expected:<...lException: Feature:[]notExist1
not found ...> but was:<...lException: Feature:[ ]notExist1 not found ...>
at
__randomizedtesting.SeedInfo.seed([73B50C5A7808D84B:C6645429244A1994]:0)
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at
org.apache.solr.ltr.model.TestLinearModel.notExistentFeature_shouldThrowMeaningFulException(TestLinearModel.java:253)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:942)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:978)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:992)
at
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
{noformat}
> Learning To Rank model upload fails generically
> -----------------------------------------------
>
> Key: SOLR-15149
> URL: https://issues.apache.org/jira/browse/SOLR-15149
> Project: Solr
> Issue Type: Bug
> Components: contrib - LTR
> Reporter: Alessandro Benedetti
> Assignee: Alessandro Benedetti
> Priority: Major
> Fix For: 8.9
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When uploading a model, using a not existent store or other incorrect
> parameters you get:
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","java.lang.ClassCastException"],
> "msg":"org.apache.solr.ltr.model.ModelException: Model type does not
> exist org.apache.solr.ltr.model.LinearModel",
> "code":400}}
> In the response, logs don't help that much out of the box, I had to go for
> remote debugging and of course we don't want the generic user to do that.
> Reason is in org/apache/solr/ltr/model/LTRScoringModel.java:111
> {code:java}
> try {
> // create an instance of the model
> model = solrResourceLoader.newInstance(
> className,
> LTRScoringModel.class,
> new String[0], // no sub packages
> new Class[] { String.class, List.class, List.class, String.class,
> List.class, Map.class },
> new Object[] { name, features, norms, featureStoreName,
> allFeatures, params });
> if (params != null) {
> SolrPluginUtils.invokeSetters(model, params.entrySet());
> }
> } catch (final Exception e) {
> throw new ModelException("Model type does not exist " + className, e);
> }
> {code}
> This happens when:
> - use a not existent feature store
> - use not existent feature
> - use an integer instead of Double as a weight in a linear model
> unless any objection, we should improve such message with the real one
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
