rmuir commented on a change in pull request #2414:
URL: https://github.com/apache/lucene-solr/pull/2414#discussion_r580272140



##########
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java
##########
@@ -49,20 +51,25 @@
  * shared by multiple spell-checkers in different threads).
  */
 public class Hunspell {
+  static final long SUGGEST_TIME_LIMIT = 250;

Review comment:
       for the case 2, I just want to be extra paranoid and avoid any 
time-dependent tests. We've got battle scars here, we've had to wrestle with 
bugs in mac OS causing nanotime to go backwards. At my day job I recently spent 
a lot of time debugging such issues with hypervisors in jenkins (crazy 
jumps/stalls etc). It is very annoying to debug these issues even when code is 
doing the correct thing and using monotonic clock (like this PR).
   
   So my point is the machine doesn't necessarily have to be crazy "fast" or 
"slow", especially with virtualization. Crazy stuff can and will happen, so if 
we can add extra caution for the tests it will be helpful in preventing flaky 
failures




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to