epugh commented on a change in pull request #2430:
URL: https://github.com/apache/lucene-solr/pull/2430#discussion_r583265431
##########
File path: solr/core/src/test/org/apache/solr/security/JWTIssuerConfigTest.java
##########
@@ -125,6 +128,31 @@ public void parseIssuerConfigExplicit() {
assertEquals("https://host/jwk";, issuerConfig.getJwksUrls().get(0));
}
+ @Test
Review comment:
This feels like using a sledgehammer on a fly... Thoughts on just
coming up with a mock in the right place? How mcuh change would it be to
introduce a mock object to return the content instead of a full blown server.
Plus, this feels like it might be slow ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
