gsmiller commented on pull request #2434: URL: https://github.com/apache/lucene-solr/pull/2434#issuecomment-789998695
As much as I like convenience, I think I lean in favor of not adding this new constructor. I also realize I'm new to this community and my opinion is not nearly as well-formed as I haven't worked in this particular codebase for very long. But... if this convenience ctor gets added, the next argument may naturally be "why not IntsRef(int[] ints, int length) that assumes it starts at zero" and so on. It's hard to draw the line on what convenience methods make sense and what don't. I personally like that this only has the necessary ctors, each of which serves obviously different functionality. Just my two cents... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
