donnerpeter commented on a change in pull request #19: URL: https://github.com/apache/lucene/pull/19#discussion_r594078718
########## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestPerformance.java ########## @@ -121,6 +131,7 @@ private void checkSuggestionPerformance(String code, int wordCount) throws Excep Hunspell speller = new Hunspell(dictionary, TimeoutPolicy.THROW_EXCEPTION, () -> {}); List<String> words = loadWords(code, wordCount, dictionary).stream() + .distinct() Review comment: Let's measure the performance of different word suggestions (we only check very few of them anyway, so let's ensure diversity). In spellchecking measurement OTOH, we check the text as it flows, with all the duplicates, to simulate real-life spellchecker ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org