mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r598287872
########## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ########## @@ -972,6 +671,64 @@ private boolean assertNotFinished() { return true; } + private FieldInfo addField( Review comment: I could not remove `add(FieldInfo fi, long dvGen)` as `TestParallelLeafReader::testWithDocValuesUpdates()` [expects dvGen to be unchanged](https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/index/TestParallelLeafReader.java#L408). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org