[ 
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307914#comment-17307914
 ] 

Robert Muir commented on LUCENE-9863:
-------------------------------------

As an example, I opened this issue because of LUCENE-9856 PR. In order to 
improve static analysis, I had to exclude some compiler warnings for generated 
files. This meant adding strings to the gradle build. 

Of course i know that single quotes and double quotes can be used. But in the 
file, no single quotes were currently in use, so I didn't want to introduce 
alien style to the file. That's a "golden rule" when you are trying to work on 
code living in chaos with no standards: try to fit to the existing style. So I 
used double quotes (with a couple of escapes). 

But i chose wrong, and it cost me about 30 minutes I can't get back because I 
had to regenerate the large DFA twice :)

> run spotless across groovy (e.g. gradle) code too
> -------------------------------------------------
>
>                 Key: LUCENE-9863
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9863
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Priority: Major
>
> We should run spotless to format the groovy, too so that there is a 
> consistent style and nobody needs to think about how the formatting should be.
> Especially considering how crazy the language is, it is even more important 
> to do this than with the java!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to