dweiss commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602577677
##########
File path: gradle/ide/eclipse.gradle
##########
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
into rootProject.file(".settings")
}
+ def ecjLintConfig =
rootProject.file("gradle/validation/ecj-lint/ecj.javadocs.prefs")
+ rootProject.file(".settings/org.eclipse.jdt.core.prefs") <<
ecjLintConfig.text.replace("=error","=warning")
Review comment:
I'd use an explicit encoding for both reading and writing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
