liupanfeng created LUCENE-9885:
----------------------------------

             Summary: error param use in RadixSelector
                 Key: LUCENE-9885
                 URL: https://issues.apache.org/jira/browse/LUCENE-9885
             Project: Lucene - Core
          Issue Type: Improvement
          Components: core/other
    Affects Versions: 8.8
            Reporter: liupanfeng


there is error param used in *org.apache.lucene.util.RadixSelector#select(int, 
int, int, int, int).*

what we expected in this method is:

if the range becomes narrow or when the maximum level of recursion has been 
exceeded, then we get a fall-back selector(IntroSelector).

so we should use the param *l* compare with *level_threshold. NOT d.*

*[effect:|http://dict.youdao.com/w/effect/#keyfrom=E2Ctranslation]*  This does 
not affect the correctness of the program. but affect performance in some case. 
RadixSelector and IntroSelector are all in linear time. but this bug made 
bigger constatns.

 

*[other evidence:|http://dict.youdao.com/w/effect/#keyfrom=E2Ctranslation]* 

1. in comment. said *maximum level of recursion has been exceeded*. not the 
length of value.

2. if *d* is right. the *param f* will never used in all method. It could be 
delete.

 

Thanks for you read. I'm new of lucene, so reply me if I am wrong. or fix it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to