zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r602745425
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -168,14 +203,34 @@ public synchronized void setIndexFieldName(String
dimName, String indexFieldName
ft.indexFieldName = indexFieldName;
}
- /** Specify whether drill down on just the dimension is necessary. */
+ /**
+ * Specify whether drill down on the dimension is necessary.
+ *
+ * @deprecated Use {@link FacetsConfig#setDrillDownTermsIndexing(String,
DrillDownTermsIndexing)}
+ * instead
+ */
+ @Deprecated
public synchronized void setRequireDimensionDrillDown(String dimName,
boolean v) {
Review comment:
Sounds good! I assume for 8.x in different repo you are referring to
this branch in the old repo right
https://github.com/apache/lucene-solr/tree/branch_8x ? And I guess back-porting
just means I need to initiate a separate PR with this change, but against that
branch / repo, and the PR will go through the same review and approval process
to be merged right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]