rmuir commented on a change in pull request #61:
URL: https://github.com/apache/lucene/pull/61#discussion_r606244542
##########
File path: gradle/generation/icu.gradle
##########
@@ -49,6 +49,13 @@ configure(project(":lucene:analysis:icu")) {
// May be undefined yet, so use a provider.
dependsOn { sourceSets.tools.runtimeClasspath }
+ // gennorm generates file order-dependent output, so make it constant here.
Review comment:
@dweiss it is my understanding order doesnt matter. so `a > b` followed
by `b > c` is the same as `b > c` followed by `a > b`. the normalization will
happen recursively so that 'a' maps to 'c' in either case. this recursive
process happens at gennorm2 'compile time'. but in version 2 of the file
format, they added a mechanism to recover the original non-recursive mappings,
so this may cause a data file change even though semanticw are unchanged? just
my guess... more details:
http://site.icu-project.org/design/normalization/custom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
