[ 
https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318575#comment-17318575
 ] 

Dawid Weiss commented on LUCENE-9921:
-------------------------------------

> so I'm curious if the ICU version can be treated as an "input" to these 
> tasks, such that if it changes, tasks know the generated output is stale?

The checksumming hack currently uses file inputs/outputs only (while gradle 
tasks can use many different input types - properties, serializable types, 
etc.). This indeed is a problem with tasks that have non-file inputs (such as 
properties, library versions or files downloaded from the web, which don't 
exist in the repository for checkums checks - chicken and egg problem here). 

I don't know if it makes sense to put much effort into making it smarter than 
it is though. It serves the purpose (checksum validation of output files) and 
if you know what you're doing you can force-regenerate via {{--rerun-tasks}}. 
Adding properties or other stuff will make that "wrapper" code even more 
complex than it already is.... and it is pretty complex already.


> Can ICU regeneration tasks treat icu version as input?
> ------------------------------------------------------
>
>                 Key: LUCENE-9921
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9921
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Priority: Major
>
> ICU 69 was released, so i was playing with the upgrade just to test it out 
> and test out our regeneration.
> Running {{gradlew regenerate}} naively wasn't helpful, regeneration tasks 
> were SKIPPED by the build.
> So I'm curious if the ICU version can be treated as an "input" to these 
> tasks, such that if it changes, tasks know the generated output is stale?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to