[
https://issues.apache.org/jira/browse/LUCENE-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318589#comment-17318589
]
ASF subversion and git services commented on LUCENE-9923:
---------------------------------------------------------
Commit f33335157d0cdeb8c3600b3ef98683d12c4eaf03 in lucene's branch
refs/heads/main from Robert Muir
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=f333351 ]
LUCENE-9923: remove always-changing timestamp from ASCIITLD.jflex generation
(#76)
This makes regenerate idempotent by removing the new Date() from the
output.
We already have the root.zone's Last-Modified date, which is the one
that matters and only changes when the root.zone changes.
> remove timestamp from generated ASCIITLD.jflex
> ----------------------------------------------
>
> Key: LUCENE-9923
> URL: https://issues.apache.org/jira/browse/LUCENE-9923
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This causes the generation to always make changes to the file, even if the
> list of TLDs has changed. Let's avoid this as generating the resultant
> tokenizer is not trivial :)
> Also if we fix this, it allows us to run ./gradlew regenerate --rerun-tasks
> and have no local changes (idempotency everywhere)
> Diffs currently look like this:
> {noformat}
> ---
> a/lucene/analysis/common/src/java/org/apache/lucene/analysis/email/ASCIITLD.jflex
> +++
> b/lucene/analysis/common/src/java/org/apache/lucene/analysis/email/ASCIITLD.jflex
> @@ -16,7 +16,7 @@
> */
> // Generated from IANA Root Zone Database
> <https://www.internic.net/zones/root.zone>
> // file version from 2021 Apr 10, Sat 17:37:00 Coordinated Universal Time
> -// generated on 2021 Apr 10, Sat 17:55:26 Coordinated Universal Time
> +// generated on 2021 Apr 10, Sat 18:13:07 Coordinated Universal Time
> // by org.apache.lucene.analysis.standard.GenerateJflexTLDMacros
> // LUCENE-8278: None of the TLDs in {ASCIITLD} is a 1-character-shorter
> prefix of another TLD
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
