rmuir commented on pull request #119: URL: https://github.com/apache/lucene/pull/119#issuecomment-830573541
Also, just casually browsing and randomly clicking the first file that looked interesting, I see huge chunks of untested code that surprised me. So I really do think the problem is just that nobody is looking at code coverage, anywhere. For example it seems CMS's iothrottle logic is completely untested due to the fact that no merges exceed `MIN_BIG_MERGE_MB`? If you hover over `if mergeMB < MIN_MERGE_MB` statement, it explains that one of two branches are missed. so maybe this parameter should be exposed via setter at least so we can test it. Just trying to make the argument for at least making steps to get more visibility on code coerage.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
