mikemccand commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-854820485


   Thank you for the ascii-art explanation of neighbor versus consumed holes!
   
   Do we also handle the neighbor-hole case when there is more than one long 
path?
   
   E.g. if the document has `the wizard of oz`, and we overlay `the_wizard` 
(pos len 2) and also `the_wizard_of_oz` (pos len 4) shingles on top of that, 
then run through `StopFilter` which deletes `the` (hmm and also `of`, but 
ignore that consumed hole for now), then we have a neighbor hole with three 
paths (the original tokens plus the two shingles).  Do we handle that / have a 
test case for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to