dsmiley commented on a change in pull request #2508:
URL: https://github.com/apache/lucene-solr/pull/2508#discussion_r647761533



##########
File path: 
solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java
##########
@@ -774,6 +763,30 @@ public Long parseAndAddGap(@SuppressWarnings("rawtypes") 
Comparable value, Strin
     }
   }
 
+  private static class EnumCalc extends Calc {
+
+    private final EnumMapping mapping;
+    public EnumCalc(final SchemaField f) {
+      super(f);
+      mapping = ((AbstractEnumField)field.getType()).getEnumMapping();
+    }
+    @Override
+    public EnumFieldValue bitsToValue(long bits) {
+      Integer val = (int)bits;
+      return new EnumFieldValue(val, mapping.intValueToStringValue(val));
+    }
+    @Override
+    protected EnumFieldValue parseStr(String rawval) {

Review comment:
       I'm missing the point.  I had set a breakpoint but it didn't hit, which 
caused me to write what I wrote.  The test uses XML (because of the XPath based 
asertions) which is fairly realistic.  Would another format perturb the bug?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to