[
https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383314#comment-17383314
]
David Smiley commented on LUCENE-9959:
--------------------------------------
Rob, please don't needlessly personalize your critical feedback towards me, and
plus the swearing just magnifies whatever your message is against the person
and not the code. And I'm sure you are smart enough to look at just about
anyone's work and understand where the motivation comes from, even if you don't
agree with the approach. Let's not talk to each other or each other's code in
this way.
I'm not pleased with the extra public class either –
[https://github.com/apache/lucene/pull/180#pullrequestreview-686320076] I said
as much. At least "Fields" can become purely internal and thus the net change
is just one more class for TVs (Zach added "TermVectors"). In
[https://github.com/apache/lucene/pull/180#issuecomment-876482149] I thought of
an approach that may work but last night I had second thoughts and went for
simplicity of the change (adding DocTermVectors). Based on your feedback Rob,
lets ignore what I came up with last night and I'll post a different PR that
doesn't introduce it.
> Can we remove threadlocals of stored fields and term vectors
> ------------------------------------------------------------
>
> Key: LUCENE-9959
> URL: https://issues.apache.org/jira/browse/LUCENE-9959
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> [~rmuir] suggested removing these threadlocals at
> https://github.com/apache/lucene/pull/137#issuecomment-840111367.
> These threadlocals are trappy if you manage many segments and threads within
> the same JVM, or worse: non-fixed threadpools. The challenge is to keep the
> API easy to use.
> We could take advantage of 9.0 to change the stored fields API?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
