[ 
https://issues.apache.org/jira/browse/LUCENE-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386525#comment-17386525
 ] 

Michael Sokolov commented on LUCENE-10034:
------------------------------------------

This is so confusing! I made the same error several times. Sign errors are the 
bane of mathematics

> Vectors NeighborQueue MIN/MAX heap reversed?
> --------------------------------------------
>
>                 Key: LUCENE-10034
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10034
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Mayya Sharipova
>            Priority: Trivial
>
> NeighborQueue is defined as following:
> {code:java}
> NeighborQueue(int initialSize, boolean reversed) {
>   if (reversed) {
>     heap = LongHeap.create(LongHeap.Order.MAX, initialSize);
>   } else {
>     heap = LongHeap.create(LongHeap.Order.MIN, initialSize);
>   }
> }
> {code}
> should it be reversed? should it be instead using MIN heap for reversed 
> functions such as EUCLIDEAN  distance, as we are interested in neigbors with 
> min euclidean distances? 
> I apologize if I missed some broader context where this definition makes 
> sense. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to