jtibshirani commented on a change in pull request #232:
URL: https://github.com/apache/lucene/pull/232#discussion_r683543464
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -146,7 +146,7 @@ public LRUQueryCache(
* of the top-level query will be cached in order to not hurt latency too
much because of caching.
*/
public LRUQueryCache(int maxSize, long maxRamBytesUsed) {
- this(maxSize, maxRamBytesUsed, new MinSegmentSizePredicate(10000, .03f),
250);
+ this(maxSize, maxRamBytesUsed, new MinSegmentSizePredicate(10000, .03f),
10);
Review comment:
Working on this change made me wonder if `QueryCachingPolicy` should
decide when to skip caching, as opposed to `LRUQueryCache`. In this case
`skipCacheFactor` would move to `UsageTrackingQueryCachingPolicy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
