jtibshirani commented on a change in pull request #239:
URL: https://github.com/apache/lucene/pull/239#discussion_r685299100
##########
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java
##########
@@ -42,13 +42,6 @@
}
}
- NeighborQueue copy(boolean reversed) {
Review comment:
It was previously used in `HnswGraph#search` but this PR removed that.
##########
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java
##########
@@ -136,7 +136,7 @@ public void setInfoStream(InfoStream infoStream) {
void addGraphNode(float[] value) throws IOException {
NeighborQueue candidates =
HnswGraph.search(
- value, beamWidth, beamWidth, vectorValues, similarityFunction,
hnsw, random);
+ value, beamWidth, beamWidth, vectorValues, similarityFunction,
hnsw, null, random);
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
