msokolov commented on a change in pull request #235:
URL: https://github.com/apache/lucene/pull/235#discussion_r686891113
##########
File path:
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java
##########
@@ -43,9 +43,9 @@ public float compare(float[] v1, float[] v2) {
};
/**
- * If true, the scores associated with vector comparisons are in reverse
order; that is, lower
- * scores represent more similar vectors. Otherwise, if false, higher scores
represent more
- * similar vectors.
+ * If true, the scores associated with vector comparisons are nonnegative
and in reverse order;
+ * that is, lower scores represent more similar vectors. Otherwise, if
false, higher scores
+ * represent more similar vectors, and scores may be negative or positive.
Review comment:
heh, in fact this edit was never needed since we never changed the
similarity scores (as I mentioned above), and only the scores returned from
search... so I'll indeed revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
