mikemccand commented on pull request #245: URL: https://github.com/apache/lucene/pull/245#issuecomment-900601218
> I like how easy it is to use from tests, just migrate from `new BytesRef(...` to `newBytesRef(...`. Yeah! Just remove the one space character! > As followup issues, we can look into migrating some more tests (especially more BaseXYZTestCase for other portions of the index format, so we at least know IW behaves). A few of them are already done here in this PR. +1 I just picked a few "interesting" tests to switch over, and they seem to be passing at least after a few top-level `gradlew test` iterations. Progress not perfection! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
