wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-904685835
> I reviewed the change more deeply today and found a few minor issues that I pushed fixes for, feel free to let me know if they don't work for you! One major issue that I found however is that binary content gets written to the file because of `MultiLevelSkipListWriter#writeSkip` which uses `writeVLong`. Can you look into writing data in a text format instead? MultiLevelSkipListWriter will write length uses writeVLong for every level, and will write childPointer for all blocks except the blocks in the lowest level uses writeVLong, can we define two methods to write these values, so that subclass can overwrite, but the default implement is writeVlong. And at the same time, MultiLevelSkipListReader also define two corresponding methods to read that values. is that ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
