[ 
https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406043#comment-17406043
 ] 

Uwe Schindler commented on LUCENE-10074:
----------------------------------------

I agree with Robert.
In general, I prefer final variables (and fields), in which case the 
initialization should be done differently. This mostly affects if/then/else 
chains, where initialization to a default before the chain is bad code 
practice, because is hard to follow when or if at all a value is assigned.

> Remove unneeded default value assignment
> ----------------------------------------
>
>                 Key: LUCENE-10074
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10074
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Zach Chen
>            Priority: Minor
>
> This is a spin-off issue from discussion here 
> [https://github.com/apache/lucene/pull/128#discussion_r695669643,] where we 
> would like to see if there's any automatic checking mechanism (ecj ?) that 
> can be enabled to detect and warn about unneeded default value assignments in 
> future changes, as well as in the existing code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to