[ 
https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407693#comment-17407693
 ] 

Julie Tibshirani commented on LUCENE-10063:
-------------------------------------------

I noticed a few test failures pop up. Here are reproduction lines:

{code}
./gradlew test --tests 
TestSimpleTextKnnVectorsFormat.testRandomWithUpdatesAndGraph 
-Dtests.seed=8FEDEC85BA7F05D7
{code}

{code}
./gradlew test --tests TestKnnVectorQuery -Dtests.codec=SimpleText
{code}

I also realized we maybe forgot to account for {{Bits acceptDocs}} in the 
search method?

> SimpleTextKnnVectorsReader.search needs an implementation
> ---------------------------------------------------------
>
>                 Key: LUCENE-10063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10063
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Blocker
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> SimpleText doesn't implement vector search today by throwing an 
> UnsupportedOperationException. We worked around this by disabling SimpleText 
> on tests that use vectors until now, but this isn't a good solution: 
> SimpleText should implement APIs correctly and only be disabled on tests that 
> expect a binary format or that are too slow with SimpleText.
> Let's implement this method via linear scan for now?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to