[
https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413450#comment-17413450
]
Ankur edited comment on LUCENE-10070 at 9/11/21, 1:11 AM:
----------------------------------------------------------
[~gsmiller] Thanks for taking a look at the above PR.
I incorporated your feedback into the changes capture in a different PR due to
GIT related issues at my end.
Request you to continue the conversation there.
[https://github.com/apache/lucene/pull/293/files]
was (Author: goankur):
[~gsmiller] Thanks for taking a look the the above PR.
I incorporated your feedback into the changes capture in a different PR due to
GIT related issues at my end.
Request you to continue the conversation there.
https://github.com/apache/lucene/pull/293/files
> "count all" faceting functionality counts deleted docs for multiple
> implementations
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-10070
> URL: https://issues.apache.org/jira/browse/LUCENE-10070
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A few different {{Facets}} implementations supporting a "count all" style
> constructor that allows the user to not pass in a {{FacetsCollector}}
> instance. It advertises that it's equivalent to using a {{FacetsCollector}}
> populated with a {{MatchAllDocsQuery}}, but more efficient. It looks like,
> with the exception of {{FastTaxonomyFacetCounts}}, none of the
> implementations correctly account for deleted documents (have a look at
> {{FastTaxonomyFacetCounts}} for a correct example that consults "live docs."
> From what I can tell, the affected implementations are:
> * SortedSetDocValueFacetCounts
> * ConcurrentSortedSetDocValueFacetCounts
> * LongValueFacetCounts
> * StringValueFacetCounts
> I'll attach a PR shortly illustrating unit tests I wrote that confirm the bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
