[
https://issues.apache.org/jira/browse/LUCENE-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417474#comment-17417474
]
ASF subversion and git services commented on LUCENE-10114:
----------------------------------------------------------
Commit 075d801abe46667f8391c20df8bafbefdcdf9492 in lucene's branch
refs/heads/main from Uwe Schindler
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=075d801 ]
LUCENE-10114: Remove unused byte order mark in Lucene90PostingsWriter (#309)
Co-authored-by: Robert Muir <[email protected]>
> Remove unused byte order mark in Lucene90PostingsWriter
> -------------------------------------------------------
>
> Key: LUCENE-10114
> URL: https://issues.apache.org/jira/browse/LUCENE-10114
> Project: Lucene - Core
> Issue Type: Task
> Components: core/codecs, core/index
> Affects Versions: main (9.0)
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Major
> Fix For: main (9.0)
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While reviewing the byte order in lucene index, I found the following code in
> {{Lucene90PostingsWriter}}:
> {code:java}
> ByteOrder byteOrder = ByteOrder.nativeOrder();
> if (byteOrder == ByteOrder.BIG_ENDIAN) {
> docOut.writeByte((byte) 'B');
> } else if (byteOrder == ByteOrder.LITTLE_ENDIAN) {
> docOut.writeByte((byte) 'L');
> } else {
> throw new Error();
> }
> {code}
> Actually this byte is consumed nowhere, as the file is only used via seeking
> and the offsets are just 1 larger. We should remove this code.
> Why was this added?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
