[ 
https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420973#comment-17420973
 ] 

ASF subversion and git services commented on LUCENE-10070:
----------------------------------------------------------

Commit ed407209409eb3af1e05d5051c5c529c64419246 in lucene-solr's branch 
refs/heads/branch_8x from Greg Miller
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ed40720 ]

LUCENE-10070: Skip deleted documents during facet counting for all documents 
(#2584)



> "count all" faceting functionality counts deleted docs for multiple 
> implementations
> -----------------------------------------------------------------------------------
>
>                 Key: LUCENE-10070
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10070
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Greg Miller
>            Priority: Minor
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> A few different {{Facets}} implementations supporting a "count all" style 
> constructor that allows the user to not pass in a {{FacetsCollector}} 
> instance. It advertises that it's equivalent to using a {{FacetsCollector}} 
> populated with a {{MatchAllDocsQuery}}, but more efficient. It looks like, 
> with the exception of {{FastTaxonomyFacetCounts}}, none of the 
> implementations correctly account for deleted documents (have a look at 
> {{FastTaxonomyFacetCounts}} for a correct example that consults "live docs."
> From what I can tell, the affected implementations are:
>  * SortedSetDocValueFacetCounts
>  * ConcurrentSortedSetDocValueFacetCounts
>  * LongValueFacetCounts
>  * StringValueFacetCounts
> I'll attach a PR shortly illustrating unit tests I wrote that confirm the bug.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to