mayya-sharipova commented on a change in pull request #315:
URL: https://github.com/apache/lucene/pull/315#discussion_r717053652
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -77,13 +80,23 @@
Lucene90HnswVectorsFormat.VECTOR_DATA_EXTENSION,
Lucene90HnswVectorsFormat.VECTOR_DATA_CODEC_NAME,
checksumRef);
- vectorIndex =
+ graphIndex =
openDataInput(
state,
versionMeta,
- Lucene90HnswVectorsFormat.VECTOR_INDEX_EXTENSION,
- Lucene90HnswVectorsFormat.VECTOR_INDEX_CODEC_NAME,
+ Lucene90HnswVectorsFormat.GRAPH_INDEX_EXTENSION,
+ Lucene90HnswVectorsFormat.GRAPH_INDEX_CODEC_NAME,
checksumRef);
+ graphData =
+ openDataInput(
+ state,
+ versionMeta,
+ Lucene90HnswVectorsFormat.GRAPH_DATA_EXTENSION,
+ Lucene90HnswVectorsFormat.GRAPH_DATA_CODEC_NAME,
+ checksumRef);
+ // fill graph nodes and offsets by level.
+ // TODO: should we do this on the first field access?
Review comment:
Addressed in 7e60c4d009652fcc6278bdb7f4a02982eb667900. Defer loading of
graph nodes and offsets to the first use
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -77,13 +80,23 @@
Lucene90HnswVectorsFormat.VECTOR_DATA_EXTENSION,
Lucene90HnswVectorsFormat.VECTOR_DATA_CODEC_NAME,
checksumRef);
- vectorIndex =
+ graphIndex =
openDataInput(
state,
versionMeta,
- Lucene90HnswVectorsFormat.VECTOR_INDEX_EXTENSION,
- Lucene90HnswVectorsFormat.VECTOR_INDEX_CODEC_NAME,
+ Lucene90HnswVectorsFormat.GRAPH_INDEX_EXTENSION,
+ Lucene90HnswVectorsFormat.GRAPH_INDEX_CODEC_NAME,
checksumRef);
+ graphData =
+ openDataInput(
+ state,
+ versionMeta,
+ Lucene90HnswVectorsFormat.GRAPH_DATA_EXTENSION,
+ Lucene90HnswVectorsFormat.GRAPH_DATA_CODEC_NAME,
+ checksumRef);
+ // fill graph nodes and offsets by level.
+ // TODO: should we do this on the first field access?
Review comment:
Addressed in 7e60c4d009652fcc6278bdb7f4a02982eb667900. Defered loading
of graph nodes and offsets to the first use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
