ChrisHegarty opened a new pull request #329:
URL: https://github.com/apache/lucene/pull/329
# Description
It is currently not possible for custom merge policies to add additional
diagnostics.
# Solution
Add a new method, `SegmentInfo::addDiagnostics`, that allows to add or
modify the segment's diagnostics.
Alternatives:
- The new method could be constrained to simply "add", rather than "modify"
(it could throw an exception if the given diagnostics map contains an entry
with a key that is already present in the segment's diagnostics )
- We could avoid the new method completely and simply expose the existing
`setDiagnostics`, by adding the public modifier.
On balance, the addition of the new `addDiagnostics` seems like a more
cooperative way for custom merge policies to behave.
# Tests
An additional test scenarios, testAddDiagnostics, has been added that
exercises the behaviour.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code
conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Lucene maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
