[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429819#comment-17429819
]
Dawid Weiss commented on LUCENE-10182:
--------------------------------------
This helps now but doesn't prevent the error in the future. Either we'd have to
block static imports or maybe (simpler) rename methods in one of these classes?
RamUsageTester.ramUsed(...) or something?
> TestRamUsageEstimator asserts trivial equality
> ----------------------------------------------
>
> Key: LUCENE-10182
> URL: https://issues.apache.org/jira/browse/LUCENE-10182
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Stefan Vodita
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{TestRamUsageEstimator.testStaticOverloads}} has serveral lines like:
> {code:java}
> assertEquals(sizeOf(array), sizeOf((Object) array));
> {code}
> Both calls to {{sizeOf()}} fall back on {{RamUsageTester.sizeOf}}, making the
> 2 calls identical. Instead, we would want one of the calls to go to
> {{RamUsageEstimator.sizeOf}}.
>
> This issue came up while working on LUCENE-10129. A possible solution, as per
> [~uschindler]'s suggestion, would be to remove the static import
> {code:java}
> import static org.apache.lucene.util.RamUsageTester.sizeOf;
> {code}
> Instead, we could be explicit on which method we are calling, like:
> {code:java}
> assertEquals(RamUsageEstimator.sizeOf(array), RamUsageTester.sizeOf(array));
> {code}
> This could be replicated for other potentially confusing cases in the test
> class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
