dsmiley commented on pull request #362: URL: https://github.com/apache/lucene/pull/362#issuecomment-949243034
I added your changes but made 3 edits: * Removed your change to the randomized highlighter configuration. It was working before; didn't need anything. Thus we want to continue to test with WEIGHT_MATCHES being off, even when the other settings allow for it to be enabled. * Thanks to the test, which failed, I realized the boolean for checking PASSAGE_RELEVANCY_OVER_SPEED was inverted. * Enhanced the added test to check how many enum values there are so that if we change these enums, we intentionally revisit the default assertions. This looks ready to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
