[ https://issues.apache.org/jira/browse/LUCENE-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437365#comment-17437365 ]
Greg Miller commented on LUCENE-10120: -------------------------------------- So I don't think there's any need to "create and discard" fixed bit sets here, but maybe I'm overlooking something. I've attached a quick patch file to show what I was thinking. This appears to pass all unit tests, but I haven't spent much time with it so it's very possible there's a bug in there. I also didn't run any benchmarks. Just wanted to share what I had in my head. > Lazy initialize FixedBitSet in LRUQueryCache > -------------------------------------------- > > Key: LUCENE-10120 > URL: https://issues.apache.org/jira/browse/LUCENE-10120 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Affects Versions: main (10.0) > Reporter: Lu Xugang > Priority: Major > Attachments: 1.png, LUCENE-10120.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Basing on the implement of collecting docIds in DocsWithFieldSet, may be we > could do similar way to cache docIdSet in > *LRUQueryCache#cacheIntoBitSet(BulkScorer scorer, int maxDoc)* when docIdSet > is density. > In this way , we do not always init a huge FixedBitSet which sometime is not > necessary when maxDoc is large > > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org