[
https://issues.apache.org/jira/browse/LUCENE-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439014#comment-17439014
]
Robert Muir commented on LUCENE-10221:
--------------------------------------
So I dug in, I tried to make a patch for this, it works fine with {{gradle test
-Dtests.directory=NIOFSDirectory}}, but then some tests fail with {{gradle test
-Dtests.directory=NIOFSDirectory -Dtests.mulitiplier=3}}. Seems some tests'
file handle usage seems to scale according to the {{tests.multiplier}}?
I tried to just set the limit based on that, but no dice:
{noformat}
> Task :lucene:core:compileTestJava FAILED
/home/rmuir/workspace/lucene/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMerging.java:34:
error: element value must be a constant expression
@HandleLimitFS.MaxOpenHandles(limit =
HandleLimitFS.MaxOpenHandles.MAX_OPEN_FILES * LuceneTestCase.RANDOM_MULTIPLIER
{noformat}
So I don't have a non-hacky way right now to contain it. Could just use
arbitrary constants, but I don't want to play whack-a-mole with that.
> Lower default file handle limit in tests to more reasonable value
> -----------------------------------------------------------------
>
> Key: LUCENE-10221
> URL: https://issues.apache.org/jira/browse/LUCENE-10221
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Major
>
> Currently the HandleLimitFS limit is set to 2048, but this already higher
> than defaults on many operating systems.
> Recently, [~dweiss] added an annotation (HandleLimitFS.MaxOpenHandles) that
> allows per-class overrides.
> So maybe we can lower the default to 1024 and annotate the long-tail
> exceptional tests as a start?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]