janhoy commented on a change in pull request #2604:
URL: https://github.com/apache/lucene-solr/pull/2604#discussion_r743823939
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/ZookeeperReadAPI.java
##########
@@ -130,6 +132,49 @@ public void listNodes(SolrQueryRequest req,
SolrQueryResponse rsp) {
}
}
+ /**
+ * Simple mime type guessing based on first character of the response
+ */
+ private String guessMime(byte firstByte) {
+ switch(firstByte) {
+ case '{':
+ return CommonParams.JSON_MIME;
+ case '<':
+ case '?':
+ return XMLResponseParser.XML_CONTENT_TYPE;
+ default:
+ return BinaryResponseParser.BINARY_CONTENT_TYPE;
+ }
+ }
+
+ /**
+ * Reads a single node from zookeeper and return as byte array
+ */
+ private byte[] readPathFromZookeeper(String path) {
+ byte[] d;
+ try {
+ d = coreContainer.getZkController().getZkClient().getData(path, null,
null, false);
+ } catch (KeeperException.NoNodeException e) {
+ throw new SolrException(SolrException.ErrorCode.NOT_FOUND, "No such
node: " + path);
+ } catch (Exception e) {
+ throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Unexpected error", e);
+ }
+ return d;
+ }
+
+ /**
+ * Reads content of a znode and adds it to the response
+ */
+ private void readNodeAndAddToResponse(String zkPath, SolrQueryRequest req,
SolrQueryResponse rsp) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
