jtibshirani commented on a change in pull request #432:
URL: https://github.com/apache/lucene/pull/432#discussion_r746919354
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java
##########
@@ -123,25 +123,17 @@ private KnnVectorsWriter getInstance(FieldInfo field)
throws IOException {
final String formatName = format.getName();
field.putAttribute(PER_FIELD_FORMAT_KEY, formatName);
- Integer suffix = null;
+ Integer suffix;
WriterAndSuffix writerAndSuffix = formats.get(format);
if (writerAndSuffix == null) {
// First time we are seeing this format; create a new instance
- String suffixAtt = field.getAttribute(PER_FIELD_SUFFIX_KEY);
Review comment:
No problem at all, this per-field logic is really tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
