dweiss commented on pull request #433: URL: https://github.com/apache/lucene/pull/433#issuecomment-966465529
I'm not a big fan of the manifest-based solution, even if I initially wrote it. If you use the module path, starting demos is fairly simple - see here: https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L661-L665 O it should be the module system that takes care of resolving dependencies, eventually (it works now but we don't leverage its full potential). Also, I don't think the demo has to be runnable from the source module directly - it'd be better to modify the docs to instruct how to build the binary distribution and run the demo from there. This does not add any new build code and makes for a single point of failure. If somebody is desperate to run from the source distribution they should build the binary release first and then follow regular demo-launching instructions from there? It should really be simple. Something like: ``` If you'd like to run Lucene demos, build the binary distribution with: gradlew -p lucene/distribution assembleBinaryTgz cd lucene/distribution/build/packages tar -zxf lucene-*.tgz cd lucene* and then run: java --module-path modules --module lucene.core/org.apache.lucene.index.CheckIndex [arguments] java --module-path modules --module lucene.demo/org.apache.lucene.demo.IndexFiles [arguments] java --module-path modules --module lucene.demo/org.apache.lucene.demo.SearchFiles [arguments] ``` I honestly see little point in adding source-level demo application assembly or direct launchers. If you work with source code, you probably use an IDE and it takes care of the dependencies for you. If you don't use the IDE... well, then the above four lines assemble everything for you. Fewer gradle build code = better. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
