gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r750605208
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##########
@@ -81,4 +84,18 @@ public long cost() {
}
};
}
+
+ /**
+ * Determine whether-or-not an index segment is using the older-style binary
format or the newer
+ * NumericDocValues format for storing taxonomy faceting ordinals (for the
specified field).
+ *
+ * @deprecated Please do not rely on this method. It is added as a temporary
measure for providing
+ * index backwards-compatibility with Lucene 8 and earlier indexes, and
will be removed in
+ * Lucene 10.
+ */
+ @Deprecated
+ public static boolean usesOlderBinaryOrdinals(LeafReader reader, String
field) {
+ FieldInfo fieldInfo = reader.getFieldInfos().fieldInfo(field);
+ return fieldInfo != null && DocValuesType.BINARY ==
fieldInfo.getDocValuesType();
Review comment:
@rmuir Apologies for the confusion. I'll have a look at your comments on
#264. This PR is against the 9.0 branch so it needs to be backwards compatible
with 8.x indexes. After iterating on this PR and merging to 9.0/9.x, my
intention is to remove back-compat support in the #264 PR (since it's against
main and won't need the back-compat considerations). I'm going to put #264 in
"draft" mode to try to avoid confusion until I come back to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
