zhaih commented on a change in pull request #442: URL: https://github.com/apache/lucene/pull/442#discussion_r751544194
########## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ########## @@ -92,15 +93,18 @@ private final Directory dir; private final IndexWriter indexWriter; private final boolean useOlderStoredFieldIndex; + private final boolean useOlderTermPositionForParentOrdinal; Review comment: Yeah I was thinking the same when making the change. I think it's not necessary to use the different variables, seems you have changed the name to `useOlderFormat`, I'll just use that name too (but I guess there'll be a merge conflict anyway, any idea on how to avoid that?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org