rmuir commented on a change in pull request #452:
URL: https://github.com/apache/lucene/pull/452#discussion_r751800229
##########
File path: gradle/generation/jflex.gradle
##########
@@ -270,6 +270,17 @@ class JFlexTask extends DefaultTask {
]
}
+ // fix invalid SuppressWarnings from jflex, so that it works with javac.
+ // we also need to suppress 'unused' because of dead code, so it passes
ecjLint
+ // you can't "stack" SuppressWarnings annotations, jflex adds its own,
this is the only way
+ // https://github.com/jflex-de/jflex/issues/762
+ project.ant.replace(
+ file: target,
+ encoding: "UTF-8",
+ token: 'SuppressWarnings("FallThrough")',
+ value: 'SuppressWarnings({"fallthrough","unused"})'
+ )
+
Review comment:
This is the hack we have to do for now, see
https://github.com/jflex-de/jflex/issues/762 where a method is being discussed
to customize the suppress warnings without find-replace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
