[ 
https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446596#comment-17446596
 ] 

Alan Woodward commented on LUCENE-10245:
----------------------------------------

The XXXValuesSource impls were originally designed for things like sorting or 
function matching which are implicitly single-valued. I can see how facets can 
usefully use multi-valued sources; if we think that multi-valued 
implementations would be generally useful then maybe we should add 
MultiXXXValuesSource/MultiXXXValues classes to core, with some helper functions 
that allow you to convert between single-valued and multi-valued 
representations?

> Allow users to provide DocValues to (some) Facets Implementations
> -----------------------------------------------------------------
>
>                 Key: LUCENE-10245
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10245
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Greg Miller
>            Priority: Minor
>
> We have some {{Facets}} implementations that do aggregations over numeric 
> values associated with each doc (e.g., {{{}DoubleRangeFacetCounts{}}}, 
> {{{}LongValueFacetCounts{}}}, etc.). These implementations allow the user to 
> either specify, 1) a field to source the doc values from, or 2) a custom 
> source of values in the form of {{{}DoubleValueSource{}}}, 
> {{{}LongValueSource{}}}, etc.
> Unfortunately, these {{xxValueSource}} implementations don't support multiple 
> values per doc, while indexed doc values do. So if the user has indexed doc 
> values they want to facet over, it works just fine if docs are multi-valued. 
> But if they want to provide a custom source of data, they're restricted to 
> single-value only.
> We should consider allowing users to provide their own doc values instances 
> in favor of the {{xxValueSource}} instances. (I'd propose we deprecate the 
> {{xxValueSource}} approach)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to