mocobeta commented on a change in pull request #473:
URL: https://github.com/apache/lucene/pull/473#discussion_r757215670
##########
File path:
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/components/dialog/menubar/AboutDialogFactory.java
##########
@@ -173,15 +172,15 @@ private JPanel footer() {
}
private static final String LUCENE_IMPLEMENTATION_VERSION =
- LucenePackage.get().getImplementationVersion();
+ Version.getPackageImplementationVersion();
private static final String LICENSE_NOTICE =
"<p>[Implementation Version]</p>"
Review comment:
Browsing through the conversation here:
Just to be more specific, how about changing this to `Lucene Implementation
Version` if we see Luke is a standalone application strictly separated from the
Lucene core module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
