mocobeta commented on a change in pull request #475:
URL: https://github.com/apache/lucene/pull/475#discussion_r757516501
##########
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##########
@@ -46,16 +43,13 @@
import org.apache.lucene.analysis.custom.CustomAnalyzer;
import org.apache.lucene.analysis.tokenattributes.CharTermAttribute;
import org.apache.lucene.luke.models.LukeException;
-import org.apache.lucene.luke.util.reflection.ClassScanner;
Review comment:
@uschindler @dweiss
There are only three FSDirectory implementations and it isn't likely to be
added as Analyzers. Maybe we should hard code the class names (FQCNs) here,
then remove `ClassScanner` from the module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
