mocobeta commented on a change in pull request #480:
URL: https://github.com/apache/lucene/pull/480#discussion_r757781501
##########
File path:
lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java
##########
@@ -152,6 +152,14 @@ public Analyzer createAnalyzerFromClassName(String
analyzerType) {
}
}
+ private Analyzer defaultAnalyzer() {
+ try {
+ return CustomAnalyzer.builder().withTokenizer("standard").build();
Review comment:
> I'd suggest to fill out the default custom analyzer on top with the
values of StandardAnalyzer.
This is actually difficult... since it would not be possible to extract
analysis components from the hard-coded Analyzers. As an alternative, we can
fill the fields with the exact same components to StandardAnalyzer, but it'd be
a temporal solution and fragile since the implementation of the
StandardAnalyzer could be changed in the future...
Or should we mimic the snapshot of the current StandardAnalyzer by
CustomAnalyzer and set it as the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
