jpountz opened a new pull request #502:
URL: https://github.com/apache/lucene/pull/502


   Currently EndiannessReverser(Data|Index)Input doesn't reverse the byte order 
for
   `readLongs` and `readFloats`. The reasoning is that these two method replaced
   `readLELongs` and `readLEFloats`, so the byte order doesn't need changing.
   
   However this is creating some confusing situations where new code expects a
   consistent byte order on the write and read sides and gets longs in the wrong
   byte order. So this commit suggests a different approach, where
   EndiannessReverser(Data|Index)Input always changes the byte order, and former
   call sites of `readLELongs` and `readLEFloats` are changed to manually 
reverse
   the byte order on top of `readLongs` and `readFloats`.
   
   This is making old codecs a bit slower, but I think it's fair since these are
   old codecs. And this makes the endianness reversing backward compatibility 
layer
   easier to reason about?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to