sonatype-lift[bot] commented on a change in pull request #503:
URL: https://github.com/apache/lucene/pull/503#discussion_r761044643



##########
File path: 
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##########
@@ -56,6 +56,26 @@ public RangeClause(byte[] lowerValue, byte[] upperValue) {
       this.lowerValue = lowerValue;
       this.upperValue = upperValue;
     }
+
+    @Override
+    public boolean equals(Object o) {

Review comment:
       *EqualsGetClass:*  Overriding Object#equals in a non-final class by 
using getClass rather than instanceof breaks substitutability of subclasses. 
[(details)](https://errorprone.info/bugpattern/EqualsGetClass)
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with 
`help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to