mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1000038312
Yes - Luke (or an example application that depends on Lucene) successfully started by just removing the test-framework module from the module path. ``` lucene $ ./gradlew assembleRelease lucene $ tar xzf lucene/distribution/build/packages/lucene-10.0.0-SNAPSHOT.tgz -C /tmp/ lucene $ /tmp/lucene-10.0.0-SNAPSHOT/bin/luke.sh Error occurred during initialization of boot layer java.lang.module.FindException: Module randomizedtesting.runner not found, required by org.apache.lucene.test_framework lucene $ rm /tmp/lucene-10.0.0-SNAPSHOT/modules/lucene-test-framework-10.0.0-SNAPSHOT.jar lucene $ /tmp/lucene-10.0.0-SNAPSHOT/bin/luke.sh # successfully launched ``` I understand this behaviour would be correct from the perspective of the module system and its internal mechanism to consume service providers in the module path. Meanwhile, it makes applications fragile (just placing one jar in the module directory breaks them). This might be documented somewhere in the specification though, it hardly seems to be very safe to me... am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
