rmuir commented on a change in pull request #572:
URL: https://github.com/apache/lucene/pull/572#discussion_r775700001
##########
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##########
@@ -343,6 +344,9 @@ private IOException convertMapFailedIOException(
CLEANER = null;
UNMAP_SUPPORTED = false;
UNMAP_NOT_SUPPORTED_REASON = hack.toString();
+ Logger.getLogger(MMapDirectory.class.getName())
+ .warning(
+ "Use of MMapDirectory was disabled by default:
".concat(UNMAP_NOT_SUPPORTED_REASON));
Review comment:
also its ok to do here if we just change the messaging to be less
confusing. i am a little afraid of adding any clinit to fsdirectory that looks
at mmapdirectory since it is the superclass of it. but maybe you know if it is
really safe :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
